Skip to content

Fix returned []byte had wrong capacity. #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2018
Merged

Fix returned []byte had wrong capacity. #766

merged 2 commits into from
Mar 8, 2018

Conversation

methane
Copy link
Member

@methane methane commented Mar 5, 2018 •
edited
Loading

fixes #765

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@methane
Copy link
Member Author

methane commented Mar 5, 2018

Test failed because of gofmt changed between Go 1.9 and 1.10.

julienschmidt
julienschmidt requested changes Mar 8, 2018
View reviewed changes
Copy link
Member

@julienschmidt julienschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase after #764 is merged, otherwise the changes seem fine to me.

@julienschmidt julienschmidt added this to the v1.4.0 milestone Mar 8, 2018
@methane methane merged commit 1a676ac into go-sql-driver:master Mar 8, 2018
@methane methane deleted the fix-765 branch March 8, 2018 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienschmidt julienschmidt julienschmidt approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

readLengthEncodedString should limit the capacity on returned byte slice.
2 participants
@methane @julienschmidt